use text-decoration-line instead of text-decoration #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukewarlow
reviewed
Dec 12, 2021
|
Worth being aware this could technically be classed a breaking change. |
|
@o-t-w I like this change. @lukewarlow can you give an example of how this could break things? Seems pretty unlikely, but maybe I'm missing something? |
|
@reinink I agree it's unlikely and someone would have to be relying on what I would agree is buggy behaviour but technically someone could be relying on the fact that text-decoration does override existing values. I just thought it was worth pointing out. I'm generally of the opinion these kinds of "breaking changes" are perfectly reasonable though. |
|
@o-t-w Hey, I forgot to say thanks when I merged this in earlier. Much appreciated! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the following code would not lead to the underline being green, which is a bug imo:
class="decoration-green-700 hover:underline hover:underline-offset-4"This is because
text-decorationis a shorthand fortext-decoration-line,text-decoration-color,text-decoration-style, andtext-decoration-thicknessso overrides any of those values (if they have been set) toinitial.