Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle color transformations properly with theme(...) for all relevant plugins #5871

Merged
merged 6 commits into from
Oct 25, 2021

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Oct 25, 2021

This PR is based on #4533, with a few more improvements. In general, the PR was good, but instead of hardcoding a list, all resolved values can handle a function. Therefore, we don't need to hardcode a list of plugins.

Background color still had to be in the first list, because a background color can have multiple values for each background. E.g.: background-color: #f00 #0f0 #00f

Closes: #4533

@RobinMalfait RobinMalfait changed the title color evaluation Improve color evaluation Oct 25, 2021
@RobinMalfait RobinMalfait changed the title Improve color evaluation Handle color transformations properly with theme(...) for all relevant plugins Oct 25, 2021
@RobinMalfait RobinMalfait merged commit 5058275 into master Oct 25, 2021
@RobinMalfait RobinMalfait deleted the color-evaluation branch October 25, 2021 10:17
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Nov 10, 2021
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Dec 17, 2021
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Dec 17, 2021
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 21, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 22, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 22, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 26, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 29, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
derTobsch pushed a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 31, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Jan 31, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
bseber added a commit to urlaubsverwaltung/urlaubsverwaltung that referenced this pull request Feb 1, 2022
NOTE:
this needs tailwindlabs/tailwindcss#5871 to be released.
currently you can patch tailwindcss/lib/util/transformThemeValue.js yourself, however :o)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant