Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neaten extract.DEFAULT resolution #5778

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Neaten extract.DEFAULT resolution #5778

merged 1 commit into from
Oct 13, 2021

Conversation

bradlc
Copy link
Contributor

@bradlc bradlc commented Oct 13, 2021

This PR updates the extract resolution so that by default, instead of { DEFAULT: undefined } you get {}

@bradlc bradlc requested a review from RobinMalfait October 13, 2021 16:08
@bradlc bradlc mentioned this pull request Oct 13, 2021
Copy link
Member

@RobinMalfait RobinMalfait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yep, I honestly didn't bother with it because I know we had the checks further along, but it is a bit cleaner indeed!

@bradlc bradlc merged commit 84a6c5d into master Oct 13, 2021
@bradlc bradlc deleted the tidy-default-extractor branch October 13, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants