Ensure variants are grouped properly for plugins with order-dependent utilities #4273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4038.
Prior to this we were using multiple
addUtilities
calls within one plugin sometimes to make sure that certain things were guaranteed to be in a certain order in JIT mode. It turns out that wasn't even necessary because we were already counting each utility in everyaddUtilities
call toward the total sort count, not just counting theaddUtilities
calls themselves.This PR collapses anywhere where we had multiple calls, as multiple calls were resulting in variants for the first call showing up in the output before non-variant utilities for subsequent calls.
Before:
After: