use word-wrap instead of overflow-wrap when targeting ie11 #2391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twhitbeck
commented
Sep 16, 2020
| @@ -1,12 +1,14 @@ | |||
| export default function() { | |||
| return function({ addUtilities, variants }) { | |||
| return function({ addUtilities, variants, target }) { | |||
| const wrapPropertyName = target('wordBreak') === 'ie11' ? 'word-wrap' : 'overflow-wrap' | |||
There was a problem hiding this comment.
I left this using overflow-wrap when not targeting ie11 since that's the official name of the property now. Technically it would be fine to just use word-wrap instead of overflow-wrap if I'm reading https://css-tricks.com/almanac/properties/o/overflow-wrap/#the-historical-word-wrap-property right. Do ya'll think I made the right call here?
|
This looks good, thanks! |
|
(Also I can't believe this was never reported until now? These utilities have just been broken for people who needed to support IE11 for 3 years?) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11 uses old
word-wrapproperty instead ofoverflow-wrap. This adjusts the output of thewordBreakplugin.