-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically add featureFlags.future
flags to the configuration files whenever the init
command is ran
#2379
Automatically add featureFlags.future
flags to the configuration files whenever the init
command is ran
#2379
Conversation
Hey thanks for this! I am not 100% convinced we need to add a Would you be open to modifying this PR to eliminate the |
Sure. I'll see if I can do that! |
- Update replace regex - Remove future CLI flag - Update tests
@adamwathan I've implemented this based on your suggestion above. I was also thinking we could do this with the experimental flags, but I wasn't sure if you wanted it in the same PR or not. Perhaps a PR title change would make sense. |
featureFlags.future
flags to the configuration files whenever the init
command is ran
Awesome, thank you! |
…les whenever the `init` command is ran (#2379) * Add --future flag to CLI * Remove early exit * Always add future flags but commented out - Update replace regex - Remove future CLI flag - Update tests
…les whenever the `init` command is ran (#2379) * Add --future flag to CLI * Remove early exit * Always add future flags but commented out - Update replace regex - Remove future CLI flag - Update tests
…les whenever the `init` command is ran (#2379) * Add --future flag to CLI * Remove early exit * Always add future flags but commented out - Update replace regex - Remove future CLI flag - Update tests
Just a heads up, I need to revert this because it completely breaks Next time please don't just change the test when you see it fail, make it pass instead :) |
Hey! Sorry, I wasn't aware of the full content within the complete config. I ended up changing to checking that the file exists as I couldn't figure out a nice way to generate the file with the automatically added future flags. I suppose it would still output as |
This PR implements the--future
flag on theinit
command which then automatically fill-in and enables the currentfeatureFlags.future
.This PR implements adding commented out
featureFlags.future
flags wheneverinit
commend is ran. This could be expanded to fill out all sorts of data and remove the manual processes that once were.This was previously mentioned in my previous PR (#2372) but I thought I'd take a shot at implementing it myself! Feedback welcome.
✅ Tests updated and passed
✅ Styles updated and passed