Added a watch mode to the build command in the CLI #2290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DCzajkowski
commented
Sep 2, 2020
Comment on lines
+88
to
+114
| /** | ||
| * Logs to the console with the last item pulled to the right edge of the terminal window. | ||
| * | ||
| * @param {...(string | [string, string])} [items] - When an item is a tuple of two strings, the first value is a | ||
| * modifier (e.g. color) that does not take any vertical space on the screen (i.e. its characters are not occupying | ||
| * available columns). The second value is a string that is visible to the user and does take vertical space. | ||
| */ | ||
| export function pad(...items) { | ||
| const paddingWidth = | ||
| process.stdout.columns - | ||
| // all strings | ||
| sum(items.map(item => (isArray(item) ? item[1] : item).length)) - | ||
| // all spaces between strings | ||
| (items.length - 1) - | ||
| // additional space character from the padding section | ||
| 1 | ||
|
|
||
| const padding = Array(paddingWidth || 0) | ||
| .fill(' ') | ||
| .join('') | ||
|
|
||
| log( | ||
| ...initial(items).map(item => (isArray(item) ? item[0](item[1]) : item)), | ||
| padding, | ||
| (item => (isArray(item) ? item[0](item[1]) : item))(last(items)) | ||
| ) | ||
| } |
There was a problem hiding this comment.
This function looks a little fragile to me, but I don't know how to make it better. Is there a package to easily offset things to the right edge? Looking forward to your feedback 🤗
|
Meant to reply to the discussion but forgot! So my go to for this is just postcss-cli which has a watch mode and works great. I am not opposed to exposing this stuff through our own CLI tool but wonder if maybe we should just build some wrapper on top of that? 🤔 |
|
No problem! :) Yeah, that makes sense! I will close this PR and update the discussions thread with current idea of implementation 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to the discussion: #2278
To be done: