Allow for deeply nested color objects #2148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the usage of deeply nested color objects, by making the
flattenColorPalette
function recursive.Currently, the
flattenColorPalette
function can flatten a palette with a total of one nested object. Which means that if we want the following output:We need to use the following color object:
Instead of the more intuitive and practical following one:
Currently, that last color object would generate the following invalid CSS:
With this pull request, it would generate the expected CSS.
Note: this is actually out of scope, but this is the second time I try to contribute to Tailwind and I'm on a Windows machine. On Windows, line endings are a mess, so I added theendOfLine: auto
rule toeslint
, and I also created a.prettierrc
file with the same rules (that would override any default IDE configuration).Normally, that wouldn't change anything for you. If you don't actually want that, I can remove them from the PR, or create a separated one.