Skip to content

Discard candidates with an empty data type #19172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
+15 −1
Merged

Discard candidates with an empty data type #19172

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
970ff52
Discard candidates with an empty data type
thecrypticace Oct 21, 2025
f261c6e
Update changelog
thecrypticace Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/tailwindcss/src/candidate.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1776,6 +1776,14 @@ it('should not parse compound group with a non-compoundable variant', () => {
expect(run('group-*:flex', { utilities, variants })).toMatchInlineSnapshot(`[]`)
})

it('empty data types are invalid', () => {
let utilities = new Utilities()
utilities.functional('bg', () => [])
let variants = new Variants()

expect(run('bg-[:foo]', { utilities, variants })).toMatchInlineSnapshot(`[]`)
})

it('should parse a variant containing an arbitrary string with unbalanced parens, brackets, curlies and other quotes', () => {
let utilities = new Utilities()
utilities.static('flex', () => [])
Expand Down
4 changes: 3 additions & 1 deletion packages/tailwindcss/src/candidate.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,7 +554,7 @@ export function* parseCandidate(input: string, designSystem: DesignSystem): Iter
if (!isValidArbitrary(arbitraryValue)) continue

// Extract an explicit typehint if present, e.g. `bg-[color:var(--my-var)])`
let typehint = ''
let typehint: string | null = null
for (let i = 0; i < arbitraryValue.length; i++) {
let code = arbitraryValue.charCodeAt(i)

Expand All @@ -580,6 +580,8 @@ export function* parseCandidate(input: string, designSystem: DesignSystem): Iter
continue
}

if (typehint === '') continue

candidate.value = {
kind: 'arbitrary',
dataType: typehint || null,
Expand Down