Fix resolve_globs crash when at root directory
#15988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
approved these changes
Jan 29, 2025
Member
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Good catch! Thank you very much
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash found in Dockerfiles when a build takes place at the root directory. It's not a good practice to keep your application logic in
/, but it probably shouldn't cause a crash either.I found this particularly difficult to write tests for because it would involve either running a glob on my real filesystem starting from
/or mocking the calls tofswhich as far as I can tell isn't supported in the codebase and would be out of scope to try to do here.Fixes #15987