Don't create bare spacing utilities with invalid multiples #14962
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14960
When we moved to the
--spacingmultiples scale, we seemingly overlooked a bail that caused us to use non-numerical values as a spacing multiple. This caused the-translate-x-fulland-translate-y-fullutilities to treatfullas a valid multiple in our spacing scale and created invalid CSS:Test plan
I reproduced the issue in our Vite playground and then created a failing test case. It requires a
--spacing@themevariable to be defined so I've added this as a test case now in the unit tests. I also audited all places that are usingcalc()and wrapping some numbers. In doing so I found a few other broken cases:-translate-x-full-translate-y-full-space-x-full-space-y-full-inset-fullI validated that the fix indeed works and no longer creates broken CSS definitions for these cases: