Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template migrations: Add automatic var injection codemods #14526
Template migrations: Add automatic var injection codemods #14526
Changes from 1 commit
b378d29
c2b28ac
821c816
6674b67
ae04af1
6135579
5522f31
514c13c
0679e8a
ebacd7c
e72c333
947eccd
dd686fb
897c8b2
80f6719
0192f66
0687077
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if these are correct, because
supports-[--test]
maps to@supports (--test: var(--tw))
which essentially tests whether the browser understands CSS variables.But
supports-[var(--test)]
maps to@supports var(--test)
which I think is invalid? (at least I can't get it to work in Safari with any value I throw at it)https://play.tailwindcss.com/CC7NDpsJfg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I got this from your list here: https://github.com/tailwindlabs/tailwindcss/pull/13657/files#diff-5c09a7c68a4426650ba1209e3be9652052750e24131acb607e09e5efea477dacR1619-R1624
supports-[var(--test)]
mapping to@supports var(--test)
seems to be at least compatible with v3 though 🙈There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I see. While this is compatible with v3, it's still wrong (aka will never match). So the question is:
--test: var(--tw)
(which essentially is the fix from 1.)