-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ellipsis and no-ellipsis utilities #1289
Conversation
I think this is probably good, my only hesitation is around whether or not we should be future proofing to support |
I am also interested in this issue, I find that I need to truncate long segments of text, which should still fill their container and not just truncate at the end of the first line. |
@adamwathan Yeah, I don't know. I was under the impression that those would not be available in browsers anytime soon, but I could be wrong. I can change this PR to use the utility names @pnadon |
@benface Finally coming back to this, what about |
Merged this manually on the command line, thanks! |
Oh hey thanks @adamwathan and sorry for not replying to your earlier comment! I was gonna update my PR (I totally agree with |
Resolves #377