Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preflight): simplify sans-serif font stack #11748

Conversation

synecdokey
Copy link
Contributor

@synecdokey synecdokey commented Aug 4, 2023

-apple-system and BlinkMacSystemFont were historically needed for IE11 and chakra-based Edge (The one that wasn't chromium-based), but that was a while ago now. I figured I could send a PR to update that.

https://caniuse.com/font-family-system-ui has more details around it/current support.

I'm also happy to provide the docs update if this gets approved!

@RobinMalfait RobinMalfait self-assigned this Aug 8, 2023
synecdokey and others added 4 commits August 8, 2023 12:08
`-apple-system` and `BlinkMacSystemFont` were historically needed for
IE11 and chakra-based Edge (The one that wasn't chromium-based).

https://caniuse.com/font-family-system-ui has more details around it.
@RobinMalfait RobinMalfait force-pushed the feat/simplify-preflight-sans-serif-font-stack branch from 7f274b8 to 6b99be3 Compare August 8, 2023 10:10
@RobinMalfait
Copy link
Member

Hey, thanks so much for this contribution! 🙏

I further simplified the sans configuration by dropping more values that aren't needed anymore. If you have a browserslist configuration that does require the fallbacks than luckily Lightning CSS will fill in the gaps for us. E.g.: Lightning CSS Playground

Since this is only a change in the value of an existing plugin, it means that the docs will automatically update once we release the next version of Tailwind CSS so no additional work has to be done there.

Thank you!

@RobinMalfait RobinMalfait merged commit 4f0bb0b into tailwindlabs:master Aug 8, 2023
10 checks passed
thecrypticace pushed a commit that referenced this pull request Dec 4, 2023
* feat(preflight): simplify sans-serif font stack

`-apple-system` and `BlinkMacSystemFont` were historically needed for
IE11 and chakra-based Edge (The one that wasn't chromium-based).

https://caniuse.com/font-family-system-ui has more details around it.

* further simplify `font-family`

* update tests

* update changelog

---------

Co-authored-by: Robin Malfait <[email protected]>
thecrypticace pushed a commit that referenced this pull request Dec 5, 2023
* feat(preflight): simplify sans-serif font stack

`-apple-system` and `BlinkMacSystemFont` were historically needed for
IE11 and chakra-based Edge (The one that wasn't chromium-based).

https://caniuse.com/font-family-system-ui has more details around it.

* further simplify `font-family`

* update tests

* update changelog

---------

Co-authored-by: Robin Malfait <[email protected]>
thecrypticace pushed a commit that referenced this pull request Dec 18, 2023
* feat(preflight): simplify sans-serif font stack

`-apple-system` and `BlinkMacSystemFont` were historically needed for
IE11 and chakra-based Edge (The one that wasn't chromium-based).

https://caniuse.com/font-family-system-ui has more details around it.

* further simplify `font-family`

* update tests

* update changelog

---------

Co-authored-by: Robin Malfait <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants