Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!important gets deleted from build when applyComplexClasses is enabled #2362

Closed
AndrewBogdanovTSS opened this issue Sep 10, 2020 · 4 comments · Fixed by #2376
Closed

!important gets deleted from build when applyComplexClasses is enabled #2362

AndrewBogdanovTSS opened this issue Sep 10, 2020 · 4 comments · Fixed by #2376

Comments

@AndrewBogdanovTSS
Copy link

One thing I just noticed when trying out applyComplexClasses in v.1.8.6 is that all of my !important statements are stripped out from the compiled code.
I use PostCSS with the next build config:

postcss: {
    // Allows the use of single line comments
    // in .pscss and .vue files
    parser: 'postcss-comment',
    plugins: {
      'postcss-import': {},
      tailwindcss: {},
      'postcss-nested': {},
      'postcss-hexrgba': {},
      'postcss-custom-properties': {
        importFrom: [{customProperties}]
      },
      autoprefixer: {}
    },
    preset: {
      // Change the postcss-preset-env settings
      autoprefixer: {
        grid: true
      }
    }
  },

than in my vue component I have

.swiper{
   &-pagination {
      bottom: -40px !important;
   }
}

resulting code just doesn't contain that !important:

.swiper-pagination {
    bottom: -40px;
}

without applyComplexClasses !important is there

I tried to use

'postcss-nested': { bubble: ['screen']},

above tailwindcss in the config but that that just makes build fail

also wanted to mention that it's not connected with purgeCSS since it was off

@adamwathan
Copy link
Member

Tried to quickly reproduce this in a test but Tailwind is preserving the !important as expected (this test passes):

test('you can still use important in nested selectors', () => {
  const input = `
    .swiper{
      &-pagination {
        bottom: -40px !important;
      }
    }
  `

  const expected = `
    .swiper{
      &-pagination {
        bottom: -40px !important;
      }
    }
  `

  return run(input).then(result => {
    expect(result.css).toMatchCss(expected)
    expect(result.warnings().length).toBe(0)
  })
})

Need a minimal reproduction I can clone down to troubleshoot any further if you don't mind.

@AndrewBogdanovTSS
Copy link
Author

AndrewBogdanovTSS commented Sep 12, 2020

@adamwathan here you go https://github.com/AndrewBogdanovTSS/tw-complex-classes
So this issue is happening when you got @apply and regular classes mixed. You can check it by going into assets/styles/layout.pcss

.NuxtLogo {
  /*Commenting this line bring !important back to life*/
  @apply mx-2 py-2;
  min-width: 320px;
  max-height: 300px !important;
}

The interesting thing is adding !important inside @apply will propagate it on all styles after it:

.NuxtLogo {
  /*Adding !important will result into getting all styles to become !important in this block*/
  @apply mx-2 py-2 !important;
  min-width: 320px;
  max-height: 300px;
}

So it's not related to postcss-nested and turning off applyComplexClasses brings it back to normal behavior

adamwathan added a commit that referenced this issue Sep 13, 2020
* Don't propogate apply !important option to non-apply rules

Fixes #2362.

* Update changelog
@adamwathan
Copy link
Member

Fixed in v1.8.9 which is out now, thanks for reporting!

@AndrewBogdanovTSS
Copy link
Author

The bug is fixed, thanks @adamwathan 👍

adamwathan added a commit that referenced this issue Sep 28, 2020
* Don't propogate apply !important option to non-apply rules

Fixes #2362.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants