Change casing of window variable on dark-mode page
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed `Window.matchMedia()` to `window.matchMedia()` to give clarity that instance method is being referred and also analogous with the given example below.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey thanks for this suggestion. So technically I think what we have here is fine given that it's a pretty common convention to refer to interfaces and classes in this way (the |
reinink
changed the title
window variable on dark-mode page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed
Window.matchMedia()towindow.matchMedia()to give clarity that method of global variablewindowis being referred instead ofWindowinterface instance method, and also analogous with the given example following the passage.