Add Tailwind CSS language mode tests #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
feat/css-server-tests
branch
5 times, most recently
from
32d1e17 to
6239d03
Compare
thecrypticace
force-pushed
the
feat/new-testing-setup
branch
from
8009fbc to
f65649f
Compare
thecrypticace
force-pushed
the
feat/css-server-tests
branch
2 times, most recently
from
0a89777 to
58e0be9
Compare
thecrypticace
force-pushed
the
feat/new-testing-setup
branch
from
f65649f to
fceef0c
Compare
thecrypticace
force-pushed
the
feat/css-server-tests
branch
from
58e0be9 to
fde6a28
Compare
RobinMalfait
approved these changes
Feb 21, 2025
Member
RobinMalfait
left a comment
RobinMalfait
left a comment
There was a problem hiding this comment.
Not 100% sure how to test it properly apart from running it locally in vscode and it seems to work as expected.
Also looks like most of it is moving things around + cleanup.
Additional tests are also nice and no older tests break so that also a win.
| }) | ||
|
|
||
| connection.onInitialize((params: InitializeParams) => { | ||
| workspaceFolders = (<any>params).workspaceFolders |
Member
There was a problem hiding this comment.
I don't think I've ever used a cast like that in TypeScript ever haha. Think I always do this:
Suggested change
| workspaceFolders = (<any>params).workspaceFolders | |
| workspaceFolders = (params as any).workspaceFolders |
Just a comment, no change required though.
thecrypticace
force-pushed
the
feat/css-server-tests
branch
from
fde6a28 to
a56c127
Compare
thecrypticace
added a commit
that referenced
this pull request
Feb 21, 2025
…nctions (#1215) Fixes #1208 Needs infrastructure from #1216 and tests --------- Co-authored-by: tizu69 <[email protected]> Co-authored-by: Robin Malfait <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a small bit of refactoring on the bundled CSS language server and adds tests for it to ensure we don't break stuff