Fix plugin compatibility with Prettier v3.7+

[thecrypticace]

This is a work in progress.

Fixes #417

Notes:

1. For some reason embed.getVisitorKeys is being called when using the Svelte plugin — but I'm pretty sure it's supposed to be optional. I don't know why bumping Prettier has caused this to happen. My temporary patch that seems to fix it is to always define it and delegate to printer.getVisitorKeys but that definitely doesn't feel right. Need to figure out why it's being called in the first place. Fixed. We should not (nor do we need to) override options.printer.

2. Some older versions of some prettier plugins we were testing against aren't compatible with v3.7. Updating them has fixed that issue though.

3. The current version (v4.0.3) of prettier-plugin-multiline-arrays is broken with Prettier v3.7+ on its own so those tests are going to fail — not related to our plugin at all:

Reproductions for that issue:

import { format } from "prettier";

// getVisitorKeys is not a function or its return value is not iterable
await format("let arr = ['one']", {
  parser: "babel",
  plugins: ["prettier-plugin-multiline-arrays"],
});

// Failed to wrap JS printer call for property "handleComments" and subProperty "remaining": 
// TypeError: Cannot read properties of undefined (reading 'value')
await format("let arr = ['one'] /** test */", {
  parser: "babel",
  plugins: ["prettier-plugin-multiline-arrays"],
});

[noga-dev]

Nice. Current solution until this gets released:

    "prettier-plugin-tailwindcss": "git://github.com:tailwindlabs/prettier-plugin-tailwindcss#ab900fa3ecdca78a2e19647336c503f9bf45e741",

[fisker]

@thecrypticace

I spend sometime to debug, seem the root cause is here

prettier-plugin-tailwindcss/src/index.ts

Line 53 in dd02e91

options.printer = printers[original.astFormat]

after parsing, the printer lost information needed in core.

[fisker]

Should we consider use a proxy here?

const embed = new Proxy(base.printers['svelte-ast'].embed, {
	apply(target, thisArgument, argumentsList) {
		const [path, options] = argumentsList;
      	mutateOriginalText(path, options)
		return Reflect.apply(target, thisArgument, argumentsList)
	}
})

just incase svelte add visitorKeys for embed in future.

[thecrypticace]

Oooh yeah, that's a good idea. Thanks!

[thecrypticace]

Do you think it's worth doing the same for print as well?

[fisker]

Yes, but currently Prettier doesn't support additional keys on it. So up to you.