Make plugin Prettier v3 only + add 3rd-party plugin support #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CJS build only supports Prettier v2 and the ESM build only supports Prettier v3. This works out fine because Prettier v3 loads plugins using `import()` and Prettier v2 loads plugins using `require()`.
thecrypticace
force-pushed
the
feat/v3-plugins
branch
from
fa61c3c to
70a4f25
Compare
thecrypticace
added a commit
that referenced
this pull request
Aug 9, 2023
thecrypticace
added a commit
that referenced
this pull request
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables support for all these plugins:
@ianvs/prettier-plugin-sort-imports@prettier/plugin-pug@shopify/prettier-plugin-liquid@trivago/prettier-plugin-sort-importsprettier-plugin-astroprettier-plugin-css-orderprettier-plugin-jsdocprettier-plugin-organize-attributesprettier-plugin-organize-importsprettier-plugin-svelteThese plugins work, as previously, but they do not "officially" support Prettier v3. However, because they do still work we've kept support for them:
prettier-plugin-import-sortprettier-plugin-style-orderThe plugins that do not work are the following:
prettier-plugin-markoprettier-plugin-twig-melodyNeither of these plugins work at present with Prettier v3 and support for them has been disabled.
As a part of this effort this plugin is now ESM only and requires Prettier v3+