Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support class:list directive of Astro #192

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Support class:list directive of Astro #192

merged 8 commits into from
Jul 27, 2023

Conversation

ony3000
Copy link
Contributor

@ony3000 ony3000 commented Jul 24, 2023

Hello!

I recently got to know the Astro framework and have been playing around with a practice project for the past few days.
However, when using the class:list directive, even if the tailwindAttributes: ['class:list'] option is set, classes are not sorted, so I opened this PR.

@thecrypticace thecrypticace self-assigned this Jul 24, 2023
@ony3000
Copy link
Contributor Author

ony3000 commented Jul 25, 2023

Oops! I missed the template literal test.
I'll turn this PR into a draft for a moment for further work.

@ony3000 ony3000 marked this pull request as draft July 25, 2023 10:10
@ony3000 ony3000 marked this pull request as ready for review July 25, 2023 11:54
@thecrypticace
Copy link
Contributor

Hey, thanks for the PR! Could you enable maintainer access to the branch? I've got some cleanups / tweaks to push before merging.

@ony3000
Copy link
Contributor Author

ony3000 commented Jul 26, 2023

Yes, I enabled maintainer access to the branch!

@thecrypticace thecrypticace merged commit e642c31 into tailwindlabs:main Jul 27, 2023
@thecrypticace
Copy link
Contributor

Updated and merged — thanks! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants