Remove support for @prettier/plugin-php
#152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
force-pushed
the
fix/remove-plugin-php-support
branch
from
75f16eb to
f650759
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #149
The PHP prettier plugin doesn’t support working with inline HTML itself. We tried to get our prettier plugin to work by treating
inlineblocks as HTML and telling prettier to format them but this has introduced complications and results in errors in some files — especially those with mixed PHP inside HTML tags.The correct way for this to work is for the PHP prettier plugin to introduce support for HTML itself and, if made to work with Prettier’s multi-language support, should theoretically run Tailwind’s prettier plugin to format classes automatically.
We were trying to be too clever here but ultimately fixing the problems would be the same as adding full HTML support to the PHP prettier plugin which is a significant undertaking and not something we're set to do.