Fix Glimmer Concatenation #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glimmer supports concatenation via the `(concat)` helper. The plugin is currently incorrectly breaking up the concatenation This adds a failing test showing the issue.
MichalBryxi
reviewed
Jan 30, 2023
|
I think, for now at least, we should special-case |
Use ignoreLast in a Glimmer StringLiteral if the parent is a SubExpression (meaning helper) and the last character of the node value is not whitespace Meaning `(concat "border-l-blue border-" @color)` does not get sorted While `(concat "border-l-blue border ")` does get sorted
The main issue is with (concat) so we will hardcode that in If in the future we think we need more helpers we can do that
Alonski
force-pushed
the
bugfix/no-fix-concat-glimmer
branch
from
a1a1946 to
4183b28
Compare
|
@thecrypticace Can you take another look please? |
|
Thanks! Will get a release out this week with this change. Appreciate it! ✨ |
|
Thank you! Can't wait! |
|
Hey @thecrypticace, |
|
@Alonski Ah sorry! This one slipped by me. Just published v0.2.3 on NPM |
|
Thanks! @MichalBryxi let's update our repo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glimmer supports concatenation via the
(concat)helper.The plugin is currently incorrectly breaking up the concatenation
I first added a failing test showing the issue.
Use ignoreLast in a Glimmer StringLiteral if the parent is a SubExpression (meaning helper) and the last character of the node value is not whitespace
Meaning
(concat "border-l-blue border-" @color)does not get sortedWhile
(concat "border-l-blue border ")does get sorted