Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vue TypeScript declarations #322

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

zmwangx
Copy link
Contributor

@zmwangx zmwangx commented Aug 1, 2021

The declarations generated by #254 aren't correct, leading to tsc errors as seen in #318.

The declarations generated by tailwindlabs#254 aren't correct, leading to tsc errors as
seen in tailwindlabs#318.
@manast
Copy link

manast commented Aug 9, 2021

Can this be merged? currently blocked by this issue when using tailwind UI components...

@VottusCode
Copy link
Contributor

The import("vue") should work normally. It always worked for me and others with Vue3+Vite+TS setups. There must be another issue why this happens.

@SniC
Copy link

SniC commented Aug 11, 2021

@VottusCode I've created an example repository here that reproduces the problem: https://github.com/SniC/heroicons-vite-typescript-problem

@bradlc
Copy link
Contributor

bradlc commented Aug 17, 2021

Thanks for this! I think it should be RenderFunction instead of DefineComponent though? I'm going to make that change then publish a new version 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants