Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Custom IAM roles in GCP #712

Merged
merged 4 commits into from
Apr 11, 2023
Merged

Add Support for Custom IAM roles in GCP #712

merged 4 commits into from
Apr 11, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

Problem

Add Support for IAM Roles (only custom roles will be fetched, the predefined 300 roles aren't displayed) in GCP
Closes #671

Solution

Screenshot_2023-04-07-21-58-32_4920x1920

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@mlabouardy mlabouardy added the gcp label Apr 7, 2023
@mlabouardy mlabouardy added this to the v3.0.12 milestone Apr 7, 2023
@ShubhamPalriwala ShubhamPalriwala changed the title Add Support for Custom IAM roles Instances in GCP Add Support for Custom IAM roles in GCP Apr 7, 2023
@ShubhamPalriwala
Copy link
Contributor Author

Merged develop, and tested the functionality post it, works as expected!

@ShubhamPalriwala
Copy link
Contributor Author

Merged develop, and tested the functionality post it, works as expected! (2) haha

@mlabouardy mlabouardy merged commit 9fc9093 into tailwarden:develop Apr 11, 2023
@ShubhamPalriwala ShubhamPalriwala mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

Assignees
No one assigned
Labels
gcp
Projects
None yet
Milestone
v3.0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhamPalriwala @mlabouardy