Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute disks #711

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Compute disks #711

merged 5 commits into from
Apr 14, 2023

Conversation

AvineshTripathi
Copy link
Collaborator

@AvineshTripathi AvineshTripathi commented Apr 7, 2023

Solution

fixes #667

Changes Made

added compute-disks

Notes

This PR will have merge conflicts again and due to bug in my local so maintainers please help me resolve those from your end. Thank you!

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Signed-off-by: AvineshTripathi <[email protected]>
Signed-off-by: AvineshTripathi <[email protected]>
@mlabouardy mlabouardy added the gcp label Apr 7, 2023
@mlabouardy mlabouardy added this to the v3.0.12 milestone Apr 7, 2023
@AvineshTripathi
Copy link
Collaborator Author

AvineshTripathi commented Apr 7, 2023

hold I think I accidently added some other code too, will remove in next commits along with reviewed changes
reason: using git add . is not good 🙃

@mlabouardy
Copy link
Collaborator

hold I think I accidently added some other code too, will remove in next commits along with reviewed changes reason: using git add . is not good 🙃

let me know when the PR is ready for review :)

Signed-off-by: AvineshTripathi <[email protected]>
@AvineshTripathi
Copy link
Collaborator Author

hold I think I accidently added some other code too, will remove in next commits along with reviewed changes reason: using git add . is not good 🙃

let me know when the PR is ready for review :)

Now it is ready for review sorry to keep you waiting @mlabouardy

@mlabouardy
Copy link
Collaborator

hold I think I accidently added some other code too, will remove in next commits along with reviewed changes reason: using git add . is not good 🙃

let me know when the PR is ready for review :)

Now it is ready for review sorry to keep you waiting @mlabouardy

awesome, thanks for the update
you would need to call your function here though

@mlabouardy mlabouardy self-requested a review April 11, 2023 12:01
Signed-off-by: AvineshTripathi <[email protected]>
@mlabouardy mlabouardy changed the base branch from master to develop April 14, 2023 12:58
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good :)

@mlabouardy mlabouardy merged commit 15a05f4 into tailwarden:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support GCP Compute disks
2 participants