Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support certificates in GCP #706

Merged
merged 1 commit into from
Apr 7, 2023
Merged

feat: support certificates in GCP #706

merged 1 commit into from
Apr 7, 2023

Conversation

ShubhamPalriwala
Copy link
Contributor

@ShubhamPalriwala ShubhamPalriwala commented Apr 6, 2023 •
edited
Loading

Problem

Add Support for Certificates in GCP in Komiser
Closes #668

How to Test

[[gcp]]
  name="demo"
  serviceAccountKeyPath="/path/to/serviceAccount/secret.json"

Screenshots

Screenshot_2023-04-06-22-14-05_4920x1920
Screenshot_2023-04-06-22-14-43_4920x1920

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

@mlabouardy mlabouardy added this to the v3.0.11 milestone Apr 6, 2023
@mlabouardy mlabouardy added the gcp label Apr 6, 2023
@mlabouardy mlabouardy merged commit 887924e into tailwarden:develop Apr 7, 2023
@ShubhamPalriwala ShubhamPalriwala mentioned this pull request Apr 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

Assignees
No one assigned
Labels
gcp
Projects
None yet
Milestone
v3.0.11
Development

Successfully merging this pull request may close these issues.
2 participants
@ShubhamPalriwala @mlabouardy