fix: cloud map error state offline mode #695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If a given user has loaded the Komiser dashboard, visited the Inventory page, lost internet connection or closed the server, then went back to the dashboard, they will be served either with a default browser error screen (i.e.: there is no internet connection...) or with the Next.js cached HTML/JS version of the page, which shows the dashboard widgets with the error state.
In the case they receive the cached version, the cloud map error state would render like this:

We use an SVG to display the world map as a placeholder, so since there is no connection to load the file, it displays its alt text instead.
Solution
Remove the alt property, so in this specific scenario of no internet connection, they would just see a blank space where the map should be.
The error state (not in offline mode) can be observed from the Storybook:
https://storybook.komiser.io/?path=/story/komiser-widgets-cloud-map--error