Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for Amazon Internet Gateways #679

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

jakepage91
Copy link
Contributor

  • Addressing ticket Tech-1021
  • Added support for fetching Amazon Internet Gateways
  • Removed ResourceARN since Internet gatways only have Resource IDs
  • I couldn't find a way to fetch the Resource Name that is not through Tags (so same value is fetched for ResourceName and ResourceID)
  • Cost is missing, addressed in an upcoming ticket.

Screenshot 2023-03-30 at 12 20 12

Copy link
Contributor

@eneskaya eneskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@mlabouardy mlabouardy added the aws label Mar 30, 2023
@mlabouardy mlabouardy added this to the v3.0.9 milestone Mar 30, 2023
@mlabouardy mlabouardy changed the base branch from master to develop March 30, 2023 12:10
@mlabouardy mlabouardy merged commit 2dfc929 into develop Mar 30, 2023
@mlabouardy mlabouardy deleted the tech-1021/support-amazon-internet-gateway branch March 30, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants