Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #628

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Conversation

GenMech
Copy link
Contributor

@GenMech GenMech commented Mar 15, 2023

Added convention for changing the base branch.

Problem

One Convention was missing that might be an issue for the new developers and they can run into conflicts while making Pull request.

Solution

To add the convention for changing the base branch.

Changes Made

Added the convention.

Checklist

  • [Yes] Code follows the contributing guidelines
  • [Yes] Changes have been thoroughly tested
  • [Yes] Documentation has been updated, if necessary
  • [Yes ] Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy

Added convention for changing the base branch.
@GenMech
Copy link
Contributor Author

GenMech commented Mar 15, 2023

@mlabouardy You can have a look!

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a million @GenMech

@mlabouardy mlabouardy added this to the v3.0.7 milestone Mar 16, 2023
@mlabouardy mlabouardy merged commit fdb2427 into tailwarden:develop Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants