Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export CSV Component #620

Merged
merged 12 commits into from
Mar 17, 2023
Merged

Export CSV Component #620

merged 12 commits into from
Mar 17, 2023

Conversation

victorgaard
Copy link
Contributor

@victorgaard victorgaard commented Mar 14, 2023 •
edited
Loading

Changes Made

  • Added Export CSV as a reusable component. This component is used both in the custom view actions dropdown and in the inventory search bar.
  • Moved inline SVGs I found in the way to icon components
  • Moved existing component InventoryViewHeader from /components/inventory to /components/inventory/view

How to Test

From the dashboard folder:

  • npm run test
  • hit p
  • type export

Screenshots

  • All resources

image

  • Filtered resources disabled state

image

  • Toast invoked

image

image

  • Custom view dropdown

image

  • Storybook

image

  • Test

image

@victorgaard victorgaard changed the base branch from develop to feature/tech-969 March 15, 2023 14:49
@victorgaard victorgaard changed the base branch from feature/tech-969 to develop March 15, 2023 14:52
@mlabouardy mlabouardy added the ui label Mar 15, 2023
@mlabouardy mlabouardy added this to the v3.0.7 milestone Mar 15, 2023
@victorgaard victorgaard marked this pull request as ready for review March 16, 2023 13:55
eneskaya
eneskaya reviewed Mar 16, 2023
View reviewed changes
dashboard/services/settingsService.ts Outdated Show resolved Hide resolved
dashboard/components/export-csv/useExportCSV.tsx Outdated Show resolved Hide resolved
dashboard/components/export-csv/ExportCSV.tsx Outdated Show resolved Hide resolved
@victorgaard
Copy link
Contributor Author

@eneskaya comments addressed!

@victorgaard victorgaard requested a review from eneskaya March 16, 2023 15:32
eneskaya
eneskaya approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@eneskaya eneskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

dammy001
dammy001 reviewed Mar 16, 2023
View reviewed changes
dashboard/services/settingsService.ts

exportCSV(id?: string) {
return window.location.replace(
`${BASE_URL}/resources/export-csv${id ? `/${id}` : ''}`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`${BASE_URL}/resources/export-csv${id ? `/${id}` : ''}`
`${BASE_URL}/resources/export-csv/${id ?? ''}`

@mlabouardy mlabouardy merged commit d4f1170 into develop Mar 17, 2023
@mlabouardy mlabouardy deleted the feature/tech-966 branch March 17, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammy001 dammy001 dammy001 left review comments

@eneskaya eneskaya eneskaya approved these changes

@mlabouardy mlabouardy Awaiting requested review from mlabouardy mlabouardy is a code owner

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
v3.0.7
Development

Successfully merging this pull request may close these issues.
4 participants
@victorgaard @eneskaya @dammy001 @mlabouardy