refactor(deps): drop direct pkcs8 dep, use rsa re-exports - #9
Merged
Conversation
The rsa 0.9 crate is pinned to pkcs8 0.10 internally, so a direct pkcs8 dependency invites renovate to keep proposing pkcs8 0.11 bumps that break the build. Source EncodePrivateKey/EncodePublicKey/LineEnding from rsa::pkcs8 instead, and enable rsa's pem feature so the PEM encoding methods stay available.
Contributor
Author
|
Thank you for reviewing 🙇♂️ I'm going to merge it 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkcs8dependency and importEncodePrivateKey/EncodePublicKey/LineEndingfromrsa::pkcs8instead.pemfeature onrsasoto_public_key_pem/to_pkcs8_derstay available.Why
The
rsa = "0.9"crate is pinned topkcs8 0.10internally. Carrying our own directpkcs8dep means renovate keeps trying to bump it to 0.11 (see #8), but the new traits are incompatible withRsaPrivateKey/RsaPublicKeyuntilrsaitself moves topkcs8 0.11. Sourcing the traits fromrsa::pkcs8removes the foot-gun — version drift can only happen when we bumprsa.Closes #8.
Test plan
cargo checkcargo clippy --all-targets -- -D warningscargo test --lib(25 passed)