Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bridge): change homepage hero for mobile view #405

Closed
wants to merge 4 commits into from
Closed

chore(bridge): change homepage hero for mobile view #405

wants to merge 4 commits into from

Conversation

Rishav1707
Copy link

This PR closes the following issues :-

closes #399

Changes made :-

  • Removing some of the CSS properties from index.tsx file.

Screenshots

Before

206601346-4c299344-5feb-4e05-9dc6-47e4b5534b72

After

Screenshot 2022-12-09 153931

@vercel
Copy link

vercel bot commented Dec 9, 2022

@Rishav1707 is attempting to deploy a commit to the taikoxyz Team on Vercel.

A member of the Team first needs to authorize it.

@Rishav1707
Copy link
Author

Please run the workflows awaiting approval... @d1onys1us @dong77 @mfinestone @RogerLamTd

@dantaik dantaik changed the title Homepage hero for mobile view has been changed. chore(bridge): change homepage hero for mobile view Dec 9, 2022
@dantaik dantaik self-requested a review December 9, 2022 15:43
@wolfderechter
Copy link
Contributor

afbeelding
Centering the button looks a little better in my opinion

@d1onys1us
Copy link
Contributor

image

As long as we are keeping that grid drawing below, I think it looks better as is. I think it would make sense to left-align things if we put that grid drawing right-aligned to the text and button. does that make sense?

@wolfderechter
Copy link
Contributor

That makes sense and I agree!

@Rishav1707
Copy link
Author

I have committed the required changes... @d1onys1us @wolfderechter @dong77 @schlusslicht
Please run the workflows.

Screenshots

Screenshot 2022-12-10 074238

@d1onys1us
Copy link
Contributor

I have committed the required changes... @d1onys1us @wolfderechter @dong77 @schlusslicht
Please run the workflows.

Screenshots

Screenshot 2022-12-10 074238

Hi @Rishav1707 I don't see what the difference is between this and the current homepage, aside from the horizontal line. I believe we want to put the grid pattern "behind" the text, or leave it as is.

@Rishav1707
Copy link
Author

@dantaik @shadab-taiko Please review my changes...

Screenshot 2022-12-10 195934

@d1onys1us
Copy link
Contributor

@dantaik @shadab-taiko Please review my changes...

Screenshot 2022-12-10 195934

@Rishav1707 Did you see my comment? We might not need this change in the current state, and instead would either 1) keep it the same or 2) move the grid background "behind" the text.

@Rishav1707
Copy link
Author

Thanks for giving me an opportunity to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update website homepage hero for mobile view
4 participants