Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(protocol): remove unused tier fee in TaikoData #17741

Merged
merged 2 commits into from
Jul 7, 2024
Merged

refactor(protocol): remove unused tier fee in TaikoData #17741

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af128ad
refactor(protocol): rm unused tier fee in TaikoData
YoGhurt111 Jul 5, 2024
0126dc1
forge fmt & update contract layout table
YoGhurt111 Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/protocol/contracts/L1/TaikoData.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,6 @@ library TaikoData {
bool checkEOAForCalldataDA;
}

/// @dev Struct representing prover fees per given tier
struct TierFee {
uint16 tier;
uint128 fee;
}

/// @dev A proof and the tier of proof it belongs to
struct TierProof {
uint16 tier;
Expand Down
9 changes: 0 additions & 9 deletions packages/protocol/test/L1/TaikoL1TestBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,6 @@ abstract contract TaikoL1TestBase is TaikoTest {
internal
returns (TaikoData.BlockMetadata memory meta, TaikoData.EthDeposit[] memory ethDeposits)
{
TaikoData.TierFee[] memory tierFees = new TaikoData.TierFee[](3);
// Register the tier fees
// Based on OPL2ConfigTier we need 3:
// - LibTiers.TIER_SGX;
// - LibTiers.TIER_OPTIMISTIC;
// - LibTiers.TIER_GUARDIAN;
tierFees[0] = TaikoData.TierFee(LibTiers.TIER_OPTIMISTIC, 1 ether);
tierFees[1] = TaikoData.TierFee(LibTiers.TIER_SGX, 1 ether);
tierFees[2] = TaikoData.TierFee(LibTiers.TIER_GUARDIAN, 0 ether);
// For the test not to fail, set the message.value to the highest, the
// rest will be returned
// anyways
Expand Down
4 changes: 0 additions & 4 deletions packages/protocol/test/L1/TaikoL1TestGroupBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ abstract contract TaikoL1TestGroupBase is TaikoL1TestBase {
internal
returns (TaikoData.BlockMetadata memory meta)
{
TaikoData.TierFee[] memory tierFees = new TaikoData.TierFee[](2);
tierFees[0] = TaikoData.TierFee(LibTiers.TIER_OPTIMISTIC, 1 ether);
tierFees[1] = TaikoData.TierFee(LibTiers.TIER_SGX, 2 ether);

TaikoData.HookCall[] memory hookcalls = new TaikoData.HookCall[](0);
bytes memory txList = new bytes(10);
bytes memory eoaSig;
Expand Down