Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bridge-ui): fix manual claim issue #17518

Merged
merged 4 commits into from
Jun 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/bridge-ui/src/components/Dialogs/Claim.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
}
}

export const claim = async (action: ClaimAction) => {
export const claim = async (action: ClaimAction, force: boolean = false) => {
if (!$account.address) {
throw new NotConnectedError('User is not connected');
}
Expand All @@ -64,15 +64,13 @@
// Step 3: get the user's wallet
const wallet = await getConnectedWallet(Number(bridgeTx.destChainId));

log(`Claiming ${bridgeTx.tokenType} for transaction`, bridgeTx);

// Step 4: Call claim() method on the bridge
let txHash: Hash;
if ($selectedRetryMethod === RETRY_OPTION.RETRY_ONCE) {
log('Claiming with lastAttempt flag');
txHash = await bridge.processMessage({ wallet, bridgeTx, lastAttempt: true });
} else {
txHash = await bridge.processMessage({ wallet, bridgeTx });
txHash = await bridge.processMessage({ wallet, bridgeTx }, force);
}

dispatch('claimingTxSent', { txHash, action });
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,11 @@

export const handleClaimClick = async () => {
claiming = true;
await ClaimComponent.claim(ClaimAction.CLAIM);
await ClaimComponent.claim(ClaimAction.CLAIM, force);
};

let force = false;
let canForceTransaction = false;
let canContinue = false;
let claiming: boolean;
let claimingDone = false;
Expand Down Expand Up @@ -122,6 +124,7 @@
const handleClaimError = (event: CustomEvent<{ error: unknown; action: ClaimAction }>) => {
//TODO: update this to display info alongside toasts
const err = event.detail.error;
canForceTransaction = true;
switch (true) {
case err instanceof NotConnectedError:
warningToast({ title: $t('messages.account.required') });
Expand Down Expand Up @@ -169,6 +172,7 @@
const reset = () => {
activeStep = INITIAL_STEP;
claimingDone = false;
canForceTransaction = false;
};

let previousStep: ClaimSteps;
Expand Down Expand Up @@ -210,6 +214,11 @@
on:claim={handleClaimClick}
bind:claiming
bind:canClaim={canContinue}
{canForceTransaction}
on:forceClaim={() => {
force = true;
handleClaimClick();
}}
bind:claimingDone />
{/if}
<div class="f-col text-left self-end h-full w-full">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,18 @@

export let txHash: Hash;

export let canForceTransaction = false;

const dispatch = createEventDispatcher();

const handleClaimClick = async () => {
dispatch('claim');
};

const handleForceClaim = async () => {
dispatch('forceClaim');
};

const getSuccessTitle = () => {
return $t('bridge.step.confirm.success.claim');
};
Expand Down Expand Up @@ -80,14 +86,23 @@
</div>
</section>
{#if !claimingDone}
<section id="actions" class="f-col w-full">
<section id="actions" class="f-col w-full gap-2">
<div class="h-sep mb-[30px]" />
<ActionButton
onPopup
priority="primary"
loading={claiming}
on:click={() => handleClaimClick()}
disabled={claimDisabled}>{$t('transactions.claim.steps.confirm.claim_button')}</ActionButton>
disabled={claimDisabled || canForceTransaction}
>{$t('transactions.claim.steps.confirm.claim_button')}</ActionButton>
{#if canForceTransaction}
<ActionButton
onPopup
priority="primary"
loading={claiming}
on:click={() => handleForceClaim()}
disabled={claimDisabled}>Force transaction</ActionButton>
{/if}
</section>
{/if}
</div>
Expand Down
43 changes: 22 additions & 21 deletions packages/bridge-ui/src/libs/bridge/Bridge.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export abstract class Bridge {
abstract estimateGas(args: BridgeArgs): Promise<bigint>;
abstract bridge(args: BridgeArgs): Promise<Hash>;

async processMessage(args: ClaimArgs): Promise<Hash> {
async processMessage(args: ClaimArgs, force = false): Promise<Hash> {
const { messageStatus, destBridgeAddress } = await this.beforeProcessing(args);
let blockNumber;

Expand Down Expand Up @@ -203,7 +203,7 @@ export abstract class Bridge {
// Initial claim
await this.beforeClaiming({ ...args, messageStatus });

txHash = await this.processNewMessage({ ...args, bridgeContract, client });
txHash = await this.processNewMessage({ ...args, bridgeContract, client }, force);
} else if (messageStatus === MessageStatus.RETRIABLE) {
// Claiming after a failed attempt
await this.beforeRetrying({ ...args, messageStatus });
Expand All @@ -225,7 +225,7 @@ export abstract class Bridge {
}
}

private async processNewMessage(args: ProcessMessageType): Promise<Hash> {
private async processNewMessage(args: ProcessMessageType, force = false): Promise<Hash> {
const { bridgeTx, bridgeContract, client } = args;
const { message } = bridgeTx;
if (!message) throw new ProcessMessageError('Message is not defined');
Expand Down Expand Up @@ -260,25 +260,26 @@ export abstract class Bridge {
console.error('Failed to estimate gas, using fallback', error);
estimatedGas = 1_300_000n;
}
if (force) {
return await writeContract(config, {
address: bridgeContract.address,
abi: bridgeContract.abi,
functionName: 'processMessage',
args: [message, proof],
gas: estimatedGas,
});
} else {
const { request } = await simulateContract(config, {
address: bridgeContract.address,
abi: bridgeContract.abi,
functionName: 'processMessage',
args: [message, proof],
gas: estimatedGas,
});
log('Simulate contract for processMessage', request);

const { request } = await simulateContract(config, {
address: bridgeContract.address,
abi: bridgeContract.abi,
functionName: 'processMessage',
args: [message, proof],
gas: estimatedGas,
});
log('Simulate contract for processMessage', request);

return await writeContract(config, request);

// return await writeContract(config, {
// address: bridgeContract.address,
// abi: bridgeContract.abi,
// functionName: 'processMessage',
// args: [message, proof],
// gas: estimatedGas,
// });
return await writeContract(config, request);
}
}

private async retryMessage(args: RetryMessageArgs): Promise<Hash> {
Expand Down
7 changes: 5 additions & 2 deletions packages/bridge-ui/src/libs/relayer/RelayerAPIService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,9 @@ export class RelayerAPIService {
data = `0x${buffer.toString('hex')}`;
}

const tokenType: TokenType = _eventToTokenType(tx.eventType);
const value = tokenType === TokenType.ETH ? BigInt(tx.amount) : BigInt(0);

const transformedTx = {
status: tx.status,
amount: BigInt(tx.amount),
Expand All @@ -187,7 +190,7 @@ export class RelayerAPIService {
srcChainId: tx.data.Message.SrcChainId,
destChainId: tx.data.Message.DestChainId,
msgHash: tx.msgHash,
tokenType: _eventToTokenType(tx.eventType),
tokenType: tokenType,
blockNumber: tx.data.Raw.blockNumber,
canonicalTokenAddress: tx.canonicalTokenAddress,
message: {
Expand All @@ -198,7 +201,7 @@ export class RelayerAPIService {
srcOwner: tx.data.Message.SrcOwner,
from: tx.data.Message.From,
gasLimit: Number(tx.data.Message.GasLimit),
value: BigInt(tx.amount),
value: value,
srcChainId: BigInt(tx.data.Message.SrcChainId),
destChainId: BigInt(tx.data.Message.DestChainId),
fee: BigInt(tx.data.Message.Fee),
Expand Down