Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): fix broken links and remove deprecated pages #13840

Merged
merged 3 commits into from
May 31, 2023

Conversation

d1onys1us
Copy link
Contributor

No description provided.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback:

  • The changes in the Pull Request look good and the link fixes seem valid.
  • There are no major bugs or typos in the code changes.
  • It would be helpful if the commit messages could be more descriptive, providing more details about the changes that were made.

@d1onys1us d1onys1us changed the title fix(website): fix broken links fix(website): fix broken links and remove deprecated pages May 30, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this pull request looks good. Here are some points to consider:

  • The link in the first patch is now pointing to the correct page.
  • The second patch removed a broken link.
  • The third patch removed some pages. It would be helpful to have a brief explanation of why these pages were removed.
  • It would be good to check if there are any typos in the variable names that are being used multiple times.

@d1onys1us d1onys1us enabled auto-merge May 30, 2023 17:25
@d1onys1us d1onys1us added this pull request to the merge queue May 31, 2023
Merged via the queue into main with commit cce7ed7 May 31, 2023
@d1onys1us d1onys1us deleted the patch-broken-link branch May 31, 2023 01:04
@github-actions github-actions bot mentioned this pull request May 31, 2023
@dantaik dantaik mentioned this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants