Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(protocol): remove unnecessary field from events #13190

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 20, 2023

@cyberhorsey Please take a look at this PR. I feel like the change may impact the Bridge backend.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #13190 (ad6ceb0) into main (667a5d9) will decrease coverage by 0.12%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##             main   #13190      +/-   ##
==========================================
- Coverage   60.79%   60.67%   -0.12%     
==========================================
  Files         115      115              
  Lines        3415     3415              
  Branches      463      463              
==========================================
- Hits         2076     2072       -4     
- Misses       1251     1256       +5     
+ Partials       88       87       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 667a5d9
protocol 51.88% <25.00%> (-0.23%) ⬇️
relayer 65.15% <ø> (ø) Carriedforward from 667a5d9
ui 100.00% <ø> (ø) Carriedforward from 667a5d9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ckages/protocol/contracts/L1/libs/LibProposing.sol 6.57% <0.00%> (ø)
packages/protocol/contracts/L2/TaikoL2.sol 53.84% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 11.90% <50.00%> (ø)
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik marked this pull request as ready for review February 20, 2023 08:44
@dantaik dantaik self-assigned this Feb 20, 2023
@cyberhorsey cyberhorsey added this pull request to the merge queue Feb 21, 2023
Merged via the queue into main with commit a40a1b6 Feb 21, 2023
@cyberhorsey cyberhorsey deleted the change_HeaderSynced branch February 21, 2023 20:18
@cyberhorsey
Copy link
Contributor

@dantaik i will make relayer and bridge changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants