Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): no longer delete commit records #13152

Merged
merged 3 commits into from
Feb 15, 2023
Merged

feat(protocol): no longer delete commit records #13152

merged 3 commits into from
Feb 15, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 14, 2023

No description provided.

@davidtaikocha davidtaikocha changed the title featI(protocol): delete commit records differently feat(protocol): delete commit records differently Feb 14, 2023
davidtaikocha
davidtaikocha previously approved these changes Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #13152 (7d9f4bf) into main (4f7ab64) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13152      +/-   ##
==========================================
- Coverage   60.95%   60.93%   -0.03%     
==========================================
  Files         115      115              
  Lines        3391     3389       -2     
  Branches      460      459       -1     
==========================================
- Hits         2067     2065       -2     
  Misses       1241     1241              
  Partials       83       83              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from b0e8d54
protocol 51.74% <ø> (-0.06%) ⬇️
relayer 66.06% <ø> (ø) Carriedforward from b0e8d54
ui 100.00% <ø> (ø) Carriedforward from b0e8d54

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ckages/protocol/contracts/L1/libs/LibProposing.sol 6.57% <ø> (+0.16%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik changed the title feat(protocol): delete commit records differently feat(protocol): no longer delete commit records Feb 14, 2023
@dantaik dantaik added this pull request to the merge queue Feb 15, 2023
Merged via the queue into main with commit edbdd3d Feb 15, 2023
@dantaik dantaik deleted the commit-records branch February 15, 2023 02:18
@github-actions github-actions bot mentioned this pull request Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants