Skip to content

Conversation

@brody4hire
Copy link
Contributor

coming from this comment: #195 (comment)

These are heavy to always be enabled, but they will be temporarily uncommented to see if they are affected by the LLVM bug if the code for this target is changed.

If we need some more info in these comments, I would appreciate any pointers to what LLVM issue(s) this is related to.

@brody4hire
Copy link
Contributor Author

I think the build failure with Rust nightly & powerpc64-ibm-aix should go away once Rust nightly includes this rollup PR: rust-lang/rust#133059 ... which includes this: rust-lang/rust#133050

@taiki-e
Copy link
Owner

taiki-e commented Nov 16, 2024

Sorry, but I don't think it is helpful to put these not very clear descriptions for each commented out code.

I this it is better to add matrix: level comments and state why some versions are commented out.

@brody4hire brody4hire changed the title add CI comments related to extra LLVM version testing add CI comments related to commented-out LLVM version entries in test matrix Nov 17, 2024
@brody4hire brody4hire force-pushed the extra-llvm-version-testing-ci-comments branch from 7b68705 to fd3d6c2 Compare November 17, 2024 02:56
@brody4hire brody4hire force-pushed the extra-llvm-version-testing-ci-comments branch from fd3d6c2 to e07531e Compare November 18, 2024 03:55
@brody4hire brody4hire marked this pull request as ready for review November 18, 2024 05:03
@brody4hire
Copy link
Contributor Author

Rewritten & rebased please let me know if anything else is needed thanks

Copy link
Owner

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@taiki-e taiki-e merged commit 391606a into taiki-e:main Nov 18, 2024
105 checks passed
@brody4hire brody4hire deleted the extra-llvm-version-testing-ci-comments branch November 19, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants