Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force proj_vis to pub(crate) if visibility cannot be parsed due to rustc bug #79

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Aug 9, 2023

Fixes #77

The visibility that has been parsed once by caller macro and can no longer be re-parsed by us (due to rustc bug) is forced to pub(crate).

Note: This would be a breaking change for macros that generate code with traits that have lower visibility than pub(crate) as a bound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This proposes a breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling pin_project with a proxy macro does not mark inner projections as pub(crate)
1 participant