Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break up __pin_project_internal #71

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Break up __pin_project_internal #71

merged 3 commits into from
Apr 21, 2022

Commits on Apr 19, 2022

  1. Reorder rules in __pin_project_internal!. 

    This isn't useful by itself, but it sets things up for the next commit,
which will break `__pin_project_internal!` into a number of smaller
macros.
    @nnethercote
    nnethercote committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    0e13089 View commit details
    Browse the repository at this point in the history

  2. Break up __pin_project_internal! into multiple rules. 

    By removal internal rules, this commit turns one giant macro with 47
rules into 23 macros with a small number of rules each. I find the
resulting code *much* easier to read; I found the original giant macro
quite overwhelming. The new code also needs fewer comments because the
code is clearer.

The commit also fixes some minor formatting inconsistencies, such as
always putting a space between the `!` and the `{` in a macro
invocation, and using parens instead of braces for a few matchers.
    @nnethercote
    nnethercote committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    d2bfd9b View commit details
    Browse the repository at this point in the history

  3. Update expected outputs.

    @nnethercote
    nnethercote committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    8b97d80 View commit details
    Browse the repository at this point in the history