Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom prefix of tags #1

Closed
taiki-e opened this issue Feb 28, 2021 · 0 comments · Fixed by #8
Closed

Support custom prefix of tags #1

taiki-e opened this issue Feb 28, 2021 · 0 comments · Fixed by #8
Labels
enhancement New feature or request

Comments

@taiki-e
Copy link
Owner

taiki-e commented Feb 28, 2021

No description provided.

@taiki-e taiki-e added the enhancement New feature or request label Jun 30, 2021
hawkw added a commit to tokio-rs/console that referenced this issue Dec 17, 2021
@hawkw
chore: just automate binary publishing for now
c889703 
Looks like Taiki's action can't currently handle tags with prefixes,
so they have to be _just_ version strings (see
taiki-e/create-gh-release-action#1).

So, we can consider automatically generating the release when it
supports tags of the format we're using (separate prefixes for each
workspace crate). For now, let's just automate the building and
uploading of release binaries, and manually create the releases...
hawkw added a commit to tokio-rs/console that referenced this issue Dec 17, 2021
@hawkw
chore: just automate binary publishing for now
802ee42 
Looks like Taiki's action can't currently handle tags with prefixes,
so they have to be _just_ version strings (see
taiki-e/create-gh-release-action#1).

So, we can consider automatically generating the release when it
supports tags of the format we're using (separate prefixes for each
workspace crate). For now, let's just automate the building and
uploading of release binaries, and manually create the releases...
hawkw added a commit to tokio-rs/console that referenced this issue Dec 17, 2021
@hawkw
chore: just automate binary publishing for now
c3a7660 
Looks like Taiki's action can't currently handle tags with prefixes,
so they have to be _just_ version strings (see
taiki-e/create-gh-release-action#1).

So, we can consider automatically generating the release when it
supports tags of the format we're using (separate prefixes for each
workspace crate). For now, let's just automate the building and
uploading of release binaries, and manually create the releases...
@hawkw hawkw mentioned this issue Dec 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for a custom tag prefix hawkw/create-gh-release-action
1 participant
@taiki-e