Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --at-least-one-of #193

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Conversation

kornelski
Copy link
Contributor

Skips powersets that don't contain any of the specified features. Can be used to test cfg-if chains of features where the last else is a compile error.

Fixes #182

@kornelski kornelski force-pushed the required-features-group branch 3 times, most recently from a1eae6d to 7cc2387 Compare September 1, 2023 16:20
@taiki-e
Copy link
Owner

taiki-e commented Sep 1, 2023

Thanks!

Could you add a test for this? (I think we can add a test that processes the input in the same way as src/main.rs#L244-L258 and checks the result, to the tests module in features.rs.)

@kornelski kornelski force-pushed the required-features-group branch 2 times, most recently from 44e9755 to 94e6832 Compare September 4, 2023 11:25
@kornelski kornelski force-pushed the required-features-group branch from 94e6832 to b71af30 Compare September 4, 2023 11:37
@kornelski
Copy link
Contributor Author

Change in MSRV is unrelated. Could be fixed with cargo update -p ctrlc --precise 3.1.4, but I don't see how this could work without lockfile and with your custom msrv workflow.

@taiki-e
Copy link
Owner

taiki-e commented Sep 4, 2023

I fixed the MSRV issue on the main branch, could you rebase?

@taiki-e taiki-e merged commit adce4da into taiki-e:main Sep 4, 2023
24 checks passed
@taiki-e
Copy link
Owner

taiki-e commented Sep 4, 2023

Published in 0.6.5. Thanks @kornelski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maybe: require one of a set of features in --feature-powerset
2 participants