Changed BytesText constructors to use utf8 types #424
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #424 +/- ##
==========================================
- Coverage 49.53% 49.37% -0.17%
==========================================
Files 22 22
Lines 13861 13860 -1
==========================================
- Hits 6866 6843 -23
- Misses 6995 7017 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dralley
commented
Jul 17, 2022
| @@ -615,9 +615,9 @@ fn test_read_write_roundtrip_escape() -> Result<()> { | |||
| match reader.read_event_into(&mut buf)? { | |||
| Eof => break, | |||
| Text(e) => { | |||
| let t = e.escape(); | |||
| let t = reader.decoder().decode(e.escape())?; | |||
There was a problem hiding this comment.
Logically the order of operations here is wrong, but as the data is already stored escaped, .escape() is a no-op, thus it doesn't really matter - and this will be cleaned up soon anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.