Add tests for BufferedInput and fix couple of bugs
#367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion and fix part of #344 As a result the same optimization is applied for borrowed parsed in DOCTYPE parsing as in non-borrowing one This fixes the following tests (which is the reason of #344): - reader::test::buffered::read_bang_element::comment::not_closed3 - reader::test::buffered::read_bang_element::comment::with_content
… when one arm is matched
Because there is the only place where cycle can be interrupted
…g `assert_eq!` This allow to see an actual comment content if test fail, but when comment was recognized
…DOCTYPE. Fix #344
This required only as intermediate step to show, that nothing is changed in the logic (Review this commit with whitespace ignored option)
(Review this commit with whitespace ignored option)
`State` from non-borrowed reader moved outside of function and renamed to `ReadElementState`; code in borrowed reader adapted
…ed only when one arm is matched
Because there is the only place where cycle can be interrupted
|
Merged in Mingun/fast-xml@9770634 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supersedes #357 because it refactors corresponding place.
This PR:
BufferedInputimplementations&[u8])Number of commits a bit more that I could prefered in the PRs, but most of them are intended to show refactoring process in order to anybody could check that behavior is not changed -- I suppose it is obvious from the commits. Therefore, I recommend review PR by commit basis. Also, each commit in a fully buildable state except 9582fe5 which is fixed by the following commit and failed by design.