-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependable codegen #95
Conversation
I am not sure I get the purpose of that change. Fyi, the protobuf parsing have been extracted into a new crate https://github.com/tafia/protobuf-parser. Do you think your change would fit better in this crate or in quick-protobuf? Again I am not sure how you use that information on your end. |
@tafia Thanks for your replay. My use case is generating the wrapper of python code generated by google protoc. As you might know, code generated by google protoc will keep the directory hierarchy and use it as the module hierarchy of generated python code. That's why I need the info of location of all the imported proto to generate my wrapper.
|
|
Merging for now because there is no reason not to. Thanks and sorry for the late answer. |
Thanks for your work on this project, Johann! I am reusing the codegen of quick-protobuf to generate some python code. I have to make this minor changes to make the codegen dependable so I think it is a good idea to merge this PR so that everyone could reuse it in similar scenarios as well.