Use chunks instead of chunks_exact
#379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `chunks_exact` method returns chunks of exactly 4 bytes, and any leftover bytes at the end of the slice are ignored. Since we know that the input slice will always be a multiple of 4 bytes per the assert, we can use the `chunks` method instead, which is slightly faster because it doesn't need to redundantly check for leftover bytes.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
chunks_exactmethod returns chunks of exactly 4 bytes, and any leftover bytes at the end of the slice are ignored.Since we know that the input slice will always be a multiple of 4 bytes per the assert, we can use the
chunksmethod instead, which is slightly faster because it doesn't need to redundantly check for leftover bytes.