Skip to content

refactor: architecture-backlog cleanups (dead schema normalizer, dialect agreement test) - #796

Merged
tada5hi merged 2 commits into
masterfrom
chore/plan-020-cleanups
Jul 20, 2026
Merged

refactor: architecture-backlog cleanups (dead schema normalizer, dialect agreement test)#796
tada5hi merged 2 commits into
masterfrom
chore/plan-020-cleanups

Conversation

@tada5hi

@tada5hi tada5hi commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Summary

Small cleanup PR from the architecture-deepening backlog (follow-up to the exploration behind #791/#792).

  • Drop core/src/schema/normalize.tsnormalizeSchemaOptions was dead code: called nowhere, exported from no barrel, and already diverged from the live Schema.extendSchemaOptions (it skipped strict entirely and name for pagination/relations). A reader learned a contract the running code doesn't honor.
  • Add an encoder ↔ tokenizer agreement spec — the codec-url expression encoder predicts tokenizer acceptance via FILTER_EXPRESSION_KEYWORDS + FILTER_FIELD_SEGMENT_PATTERN from @rapiq/parser-expression, but no test asserted the two packages agree. The new spec pins both directions: every field name the encoder accepts must decode back to the same condition, and every name it rejects (including the full exported keyword table) must also fail to decode when hand-spelled.

Checks

  • @rapiq/core: build + 361 tests pass
  • @rapiq/codec-url: 234 tests pass (incl. the new agreement spec)
  • eslint clean on the new spec

tada5hi added 2 commits July 20, 2026 12:15
normalizeSchemaOptions was called nowhere and exported from no barrel,
and had diverged from the live Schema.extendSchemaOptions (it skipped
strict entirely and name for pagination/relations).
The expression encoder predicts tokenizer acceptance via
FILTER_EXPRESSION_KEYWORDS and FILTER_FIELD_SEGMENT_PATTERN from
@rapiq/parser-expression; until now no spec asserted the prediction
against the parser's actual behavior. Pin both directions: accepted
field names must decode back to the same condition, rejected ones
must also fail to decode when hand-spelled.
Copilot AI review requested due to automatic review settings July 20, 2026 10:15

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@tada5hi, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 37 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ee2d8d27-6b63-46e2-ba16-1c46a6e3abe2

📥 Commits

Reviewing files that changed from the base of the PR and between ea8ba85 and 5b99be4.

📒 Files selected for processing (2)
  • packages/codec-url/test/unit/expression-agreement.spec.ts
  • packages/core/src/schema/normalize.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/plan-020-cleanups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tada5hi
tada5hi merged commit 4324130 into master Jul 20, 2026
7 checks passed
@tada5hi
tada5hi deleted the chore/plan-020-cleanups branch July 27, 2026 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants