Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: check for getter method ids collisions #875

Merged
merged 6 commits into from
Sep 25, 2024
Merged

fix: check for getter method ids collisions #875

merged 6 commits into from
Sep 25, 2024

Conversation

Gusarich
Copy link
Member

Issue

Closes #859.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.6.0 milestone Sep 25, 2024
@Gusarich Gusarich requested a review from a team as a code owner September 25, 2024 15:50
@Gusarich Gusarich changed the title Error on collision feat: check for method_id collisions Sep 25, 2024
@Gusarich Gusarich changed the title feat: check for method_id collisions feat: check for getter method ids collisions Sep 25, 2024
@anton-trunov anton-trunov self-assigned this Sep 25, 2024
anton-trunov
anton-trunov requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Let's also have a negative test for getters in traits, just to make sure we cover those cases too.

src/types/resolveDescriptors.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov changed the title feat: check for getter method ids collisions fix: check for getter method ids collisions Sep 25, 2024
@anton-trunov anton-trunov merged commit e69c7fc into tact-lang:main Sep 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Hash collision getter methods error
2 participants
@Gusarich @anton-trunov