Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow optional types for self argument in extends mutates functions #854

Merged
merged 8 commits into from
Oct 1, 2024
Merged

feat: allow optional types for self argument in extends mutates functions #854

merged 8 commits into from
Oct 1, 2024

Conversation

Gusarich
Copy link
Member

Issue

Closes #70.

Checklist

  • I have updated CHANGELOG.md
  • I have documented my contribution in Tact Docs: https://github.com/tact-lang/tact-docs/pull/PR-NUMBER
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.6.0 milestone Sep 19, 2024
@Gusarich Gusarich requested a review from a team as a code owner September 19, 2024 21:18
@anton-trunov anton-trunov self-assigned this Sep 23, 2024
anton-trunov
anton-trunov requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor testing suggestion

src/test/e2e-emulated/contracts/mutating-methods.tact Show resolved Hide resolved
anton-trunov
anton-trunov reviewed Oct 1, 2024
View reviewed changes
cspell.json Outdated Show resolved Hide resolved
anton-trunov
anton-trunov requested changes Oct 1, 2024
View reviewed changes
src/types/test/fun-extends-opt-self.tact Outdated Show resolved Hide resolved
src/types/test/fun-extends-opt-self.tact Outdated Show resolved Hide resolved
src/types/test/fun-extends-opt-self.tact Outdated Show resolved Hide resolved
src/types/resolveDescriptors.ts Show resolved Hide resolved
src/types/resolveDescriptors.ts Show resolved Hide resolved
src/types/resolveDescriptors.ts Show resolved Hide resolved
jeshecdom
jeshecdom approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@jeshecdom jeshecdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-trunov anton-trunov merged commit 2fea700 into tact-lang:main Oct 1, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@jeshecdom jeshecdom jeshecdom approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Allow nullable types in "extends mutates" functions
3 participants
@Gusarich @jeshecdom @anton-trunov