Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support of exotic cells #343

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Gusarich
Copy link
Member

Closes #154

[WORK IN PROGRESS]

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.4.0 milestone May 24, 2024
@Gusarich Gusarich modified the milestones: v1.4.0, v1.5.0 Jun 11, 2024
@anton-trunov anton-trunov self-assigned this Jul 27, 2024
@anton-trunov
Copy link
Member

I saw in TON dev chats interest from Tact users regarding the exotic cells support -- they would like to implement cNFTs in Tact.

@anton-trunov
Copy link
Member

@Gusarich Any progress on this?

@Gusarich
Copy link
Member Author

Gusarich commented Sep 3, 2024

@Gusarich Any progress on this?

I'm rewriting this thing because at the current state it's easier than trying to resolve all the conflicts with main branch

stdlib/stdlib.fc Outdated
Comment on lines 641 to 642
(slice, int) begin_parse_exotic(cell c) asm "XCTOS";
cell end_cell_exotic(slice s) asm "ENDXC";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also(?) add these as Tact stdlib asm-functions

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks just awesome!

@Gusarich
Copy link
Member Author

rewrote the whole thing, it kind of works (compiles at least), but it's incomplete and doesn't work properly because I didn't finish yet. I think we should move this to 1.6.0 due to a deadline

@anton-trunov anton-trunov modified the milestones: v1.5.0, v1.6.0 Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tact lacks support of exotic cells
2 participants